Feature/OIDC oauth groups #1188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flashguerdon
force-pushed
the
feature/oidc-oauth-groups
branch
2 times, most recently
from
4153fbf
to
9037de7
Compare
flashguerdon
force-pushed
the
feature/oidc-oauth-groups
branch
from
9037de7
to
3692d79
Compare
Avantol13
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Thanks folks! At a high-level this is a great direction.
Initial round of feedback complete. Light review of the testing at this point (since I expect some of it to change). Suggesting some reorganization and other minor cleanup (see comments).
Please feel free to respond to comments for clarification and/or make updates and let me know once everything has been addressed. I'll do another round of review after that.
remove trailing space Co-authored-by: Alexander VanTol <Avantol13@users.noreply.github.com>
flashguerdon
force-pushed
the
feature/oidc-oauth-groups
branch
from
e8ffbe1
to
b125321
Compare
Avantol13
requested changes
Oct 16, 2024
...to make user creation more uniform, reflecting what is also done elsewhere in fence/sync/sync_users.py _upsert_userinfo() for example
* fix use real bucket name * fix * update comment * use regex * update version
Update documentation link in setup.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features